Re: SSL Tests for sslinfo extension
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Andrew Dunstan <andrew@dunslane.net>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-17T07:29:07Z
Lists: pgsql-hackers
On Thu, May 20, 2021 at 08:40:48PM +0200, Daniel Gustafsson wrote: > > On 19 May 2021, at 21:05, Andrew Dunstan <andrew@dunslane.net> wrote: > > > > On 5/19/21 1:01 PM, Dagfinn Ilmari Mannsåker wrote: > >> Daniel Gustafsson <daniel@yesql.se> writes: > >> > >>> In order to be able to test extensions with SSL connections, allow > >>> configure_test_server_for_ssl to create any extensions passed as > >>> comma separated list. Each extension is created in all the test > >>> databases which may or may not be useful. > >> Why the comma-separated string, rather than an array reference, > >> i.e. `extensions => [qw(foo bar baz)]`? > > No real reason, I just haven't written Perl enough lately to "think in Perl". > Fixed in the attached. Hmm. Adding internal dependencies between the tests should be avoided if we can. What would it take to move those TAP tests to contrib/sslinfo instead? This is while keeping in mind that there was a patch aimed at refactoring the SSL test suite for NSS. -- Michael
Commits
-
Use test-specific temp path for keys during SSL test
- c113d8ad50d6 15.0 landed
-
Add TAP tests for contrib/sslinfo
- ae81776a23f7 15.0 landed
-
Extend configure_test_server_for_ssl to add extensions
- 879fc1a579cc 15.0 landed