Horton

Re: pg_regress.c also sensitive to various PG* environment variables

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-12T00:10:06Z
Lists: pgsql-hackers 
On Fri, Jun 11, 2021 at 10:08:20AM -0400, Alvaro Herrera wrote:
> I think if they're to be kept in sync, then the exceptions should be
> noted.  I mean, where PGCLIENTENCODING would otherwise be, I'd add
> /* PGCLIENTENCODING set above */
> /* See below for PGHOSTADDR */
> and so on (PGHOST and PGPORT probably don't need this because they're
> immediately below; not sure; but I would put them in alphabetical order
> in both lists for sure and then that wouldn't apply).  Otherwise I would
> think that it's an omission and would set to fix it.

Good idea, thanks.  I'll add comments for each one that cannot be
unsetted.
--
Michael

Commits

  1. Ignore more environment variables in pg_regress.c