Horton

Re: Added missing tab completion for alter subscription set option

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: vignesh C <vignesh21@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-11T06:56:56Z
Lists: pgsql-hackers 
On Sun, May 23, 2021 at 04:24:59PM +0530, vignesh C wrote:
>  	/* Complete "CREATE SUBSCRIPTION <name> ...  WITH ( <opt>" */
>  	else if (HeadMatches("CREATE", "SUBSCRIPTION") && TailMatches("WITH", "("))
> -		COMPLETE_WITH("copy_data", "connect", "create_slot", "enabled",
> -					  "slot_name", "synchronous_commit");
> +		COMPLETE_WITH("binary", "copy_data", "connect", "create_slot",
> +					  "enabled", "slot_name", "streaming",
> +					  "synchronous_commit");

"copy_data" and "connect" need to be reversed.  Applied.
--
Michael

Commits

  1. Improve psql tab completion for options of subcriptions and publications