Horton

Re: please update ps display for recovery checkpoint

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: "Bossart, Nathan" <bossartn@amazon.com>, Fujii Masao <masao.fujii@oss.nttdata.com>, k.jamison@fujitsu.com, Thomas Munro <thomas.munro@gmail.com>, pgsql-hackers@postgresql.org, Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Date: 2021-06-10T01:35:16Z
Lists: pgsql-hackers 
On Sun, Jun 06, 2021 at 09:13:48PM -0500, Justin Pryzby wrote:
> Putting this into fd.c seems to assume that we can clobber "ps", which is fine
> when called by StartupXLOG(), but it's a public interface, so I'm not sure if
> it's okay to assume that's the only caller.  Maybe it should check if
> MyAuxProcType == B_STARTUP.

I would be tempted to just add that into StartupXLOG() rather than
implying that callers of SyncDataDirectory() are fine to get their ps
output enforced all the time.
--
Michael

Commits

  1. Provide recovery_init_sync_method=syncfs.

  2. Add some checkpoint/restartpoint status to ps display