Re: Fix dropped object handling in pg_event_trigger_ddl_commands
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Sven Klemm <sven@timescale.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2021-06-09T05:29:32Z
Lists: pgsql-hackers
On Mon, Jun 07, 2021 at 12:44:42PM +0300, Aleksander Alekseev wrote: > I confirm that the bug still exists in master (be57f216). The patch > fixes it and looks good to me. I changed the wording a little and > added a regression test. The updated patch is in the attachment. I > added this thread to the CF and updated the status to "Ready for > Committer". FWIW, that looks rather natural to me to me to just ignore the object if it has already been dropped here. The same kind of rules apply to tables dropped with DROP TABLE which would not show up as of pg_event_trigger_ddl_commands(), but one can get a list as of pg_event_trigger_dropped_objects(). Alvaro, were you planning to look at that? I have not looked at the patch in details. missing_ok is available in getObjectIdentity() only since v14, so this cannot be backpatched :/ -- Michael
Commits
-
Improve handling of dropped objects in pg_event_trigger_ddl_commands()
- 2d689babe3cb 14.0 landed
-
Simplify some code in getObjectTypeDescription()
- b56b83aa0d6e 14.0 landed