Re: Generating code for query jumbling through gen_node_support.pl

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es

From: Michael Paquier <michael@paquier.xyz>

To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>

Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, "Drouvot, Bertrand" <bdrouvot@amazon.com>

Date: 2023-01-25T00:08:17Z

Lists: pgsql-hackers

Attachments

v7-0003-Support-for-automated-query-jumble-with-all-Nodes.patch (text/x-diff) patch v7-0003
v7-0004-Add-GUC-utility_query_id.patch (text/x-diff) patch v7-0004

On Tue, Jan 24, 2023 at 03:57:56PM +0900, Michael Paquier wrote:
> Makes sense.  That would be my intention if 0004 is the most
> acceptable and splitting things makes things a bit easier to review.

There was a silly mistake in 0004 where the jumbling code relied on
compute_query_id rather than utility_query_id, so fixed and rebased as
of v7 attached.
--
Michael

Commits

Mark more nodes with attribute no_query_jumble
- 2a507f6fd8b7 16.0 landed
Include values of A_Const nodes in query jumbling
- 9ba37b2cb6a1 16.0 landed
Generate code for query jumbling through gen_node_support.pl
- 3db72ebcbe20 16.0 landed
Rework format of comments in headers for nodes
- 5d29d525ffe0 16.0 landed
Move queryjumble.c code to src/backend/nodes/
- 8eba3e3f0208 16.0 landed
Fix some compiler warnings in aset.c and generation.c
- b82557ecc2eb 16.0 cited
Reformat some node comments
- 835d476fd21b 16.0 cited