Horton

Re: recovery modules

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2023-02-02T05:34:17Z
Lists: pgsql-hackers 
On Wed, Feb 01, 2023 at 01:23:26PM -0800, Nathan Bossart wrote:
> Yeah, that's nicer.  cfbot is complaining about a missing #include, so I
> need to send a new revision anyway.

Okay, the changes done here look straight-forward seen from here.  I
got one small-ish comment.

+basic_archive_startup(ArchiveModuleState *state)
+{
+   BasicArchiveData *data = palloc0(sizeof(BasicArchiveData));

Perhaps this should use MemoryContextAlloc() rather than a plain
palloc().  This should not matter based on the position where the
startup callback is called, still that may be a pattern worth
encouraging.
--
Michael

Commits

  1. Redesign archive modules

  2. Remove uses of AssertVariableIsOfType() obsoleted by f2b73c8

  3. Rename contrib module basic_archive to basic_wal_module

  4. Refactor code for restoring files via shell commands

  5. Refactor code in charge of running shell-based recovery commands