Horton

Re: Small miscellaneus fixes (Part II)

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Ranier Vilela <ranier.vf@gmail.com>, pgsql-hackers@postgresql.org
Date: 2022-12-21T07:10:41Z
Lists: pgsql-hackers 
On Tue, Dec 20, 2022 at 06:51:34PM -0600, Justin Pryzby wrote:
> On Fri, Nov 25, 2022 at 06:27:04PM -0300, Ranier Vilela wrote:
> > 5. Use boolean operator with boolean operands
> > (b/src/backend/commands/tablecmds.c)
> 
> tablecmds.c: right.  Since 074c5cfbf

Most of this does not seem to be really worth poking at.

    newcons = AddRelationNewConstraints(rel, NIL,
                                        list_make1(copyObject(constr)),
-                                       recursing | is_readd,   /* allow_merge */
+                                       recursing || is_readd,  /* allow_merge */
There is no damage here, but that looks like a typo so no objections
on this one.
--
Michael

Commits

  1. Remove redundant relkind check

  2. Remove dead code in formatting.c

  3. Fix operator typo in tablecmds.c