Re: pg_basebackup's --gzip switch misbehaves

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2022-11-14T23:58:29Z
Lists: pgsql-hackers
On Mon, Nov 14, 2022 at 03:27:14PM +0100, Daniel Gustafsson wrote:
> Ugh, yes, that's what it should say.

A split sounds fine by me.  On top of what Tom has mentioned, I have
spotted two small-ish things.

-    This module is available from CPAN or an operating system package.
+    This module is available from
+    <ulink url="https://metacpan.org/release/IPC-Run">CPAN</ulink>
+    or an operating system package.

It looks like there is a second one in install-windows.sgml.

+    Many operations in the test suites use a 180 second timeout, which on slow
Nit: s/180 second/180-second/?
--
Michael

Commits

  1. Make PG_TEST_NOCLEAN work for temporary directories in TAP tests

  2. doc: document the TAP test environment variables

  3. doc: update metacpan.org links to avoid redirects

  4. Use min/max bounds defined by Zstd for compression level

  5. Fix incorrect value for "strategy" with deflateParams() in walmethods.c

  6. Simplify handling of compression level with compression specifications