Horton

Re: Getting rid of SQLValueFunction

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Ted Yu <yuzhihong@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Corey Huinker <corey.huinker@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-11-21T09:38:57Z
Lists: pgsql-hackers 
On Sun, Nov 20, 2022 at 03:15:34PM -0800, Ted Yu wrote:
> + * timestamp.  These require a specific handling with their typmod is given
> + * by the function caller through their SQL keyword.
> 
> typo: typmod is given -> typmod given
> 
> Other than the above, code looks good to me.

Thanks for double-checking.  I intended a different wording, actually,
so fixed this one.  And applied after an extra round of reviews.
--
Michael

Commits

  1. Fix precision handling for some COERCE_SQL_SYNTAX functions

  2. Replace SQLValueFunction by COERCE_SQL_SYNTAX

  3. Switch SQLValueFunction on "name" to use COERCE_SQL_SYNTAX

  4. Improve coverage of ruleutils.c for SQLValueFunctions