Horton
Menu

Re: Improve logging when using Huge Pages

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: thomas.munro@gmail.com, tgl@sss.pgh.pa.us, andres@anarazel.de, john.naylor@enterprisedb.com, noriyoshi.shinoda@hpe.com, jchampion@timescale.com, sawada.mshk@gmail.com, masao.fujii@oss.nttdata.com, pryzby@telsasoft.com, pgsql-hackers@postgresql.org, rjuju123@gmail.com
Date: 2022-11-09T05:04:00Z
Lists: pgsql-hackers 
On Wed, Nov 09, 2022 at 11:47:57AM +0900, Kyotaro Horiguchi wrote:
> Honestly I don't come up with other users of the new
> log-level. Another possible issue is it might be a bit hard for people
> to connect that level to huge_pages=try, whereas I think we shouldn't
> put a description about the concrete impact range of that log-level.
> 
> I came up with an alternative idea that add a new huge_pages value
> try_report or try_verbose, which tell postgresql to *always* report
> the result of huge_pages = try.

Here is an extra idea for the bucket of ideas: switch the user-visible
value of huge_pages to 'on' when we are at "try" but success in using
huge pages, and switch the visible value to "off".  The idea of Justin
in [1] to use an internal runtime-computed GUC sounds sensible, as well
(say a boolean effective_huge_pages?).

[1]: https://www.postgresql.org/message-id/20221106130426.GG16921@telsasoft.com
--
Michael

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add GUC parameter "huge_pages_status"

  2. Add check on initial and boot values when loading GUCs

  3. Clean up some inconsistencies with GUC declarations

  4. Clean up some GUC declarations and comments