Horton

Re: Incorrect include file order in guc-file.l

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-11-03T11:40:32Z
Lists: pgsql-hackers 
On Thu, Nov 03, 2022 at 12:40:19PM +0700, John Naylor wrote:
> On Wed, Nov 2, 2022 at 1:01 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
>> Agreed, it's apparently an oversight in dac048f71eb.  +1 for the patch.
> 
> I've pushed this, thanks!

Thanks for the commit.  I've wanted to get it done yesterday but life
took over faster than that.  Before committing the change, there is
something I have noticed though: this header does not seem to be
necessary at all and it looks that there is nothing in guc-file.l that
needs it.  Why did you add it in dac048f to begin with?
--
Michael

Commits

  1. Remove unneeded includes of <sys/stat.h>

  2. Remove outdated include

  3. Straighten include order in guc-file.l