Horton

Incorrect include file order in guc-file.l

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-11-02T05:29:50Z
Lists: pgsql-hackers

Attachments

Hi all,

While reviewing a different patch, I have noticed that guc-file.l
includes sys/stat.h in the middle of the PG internal headers.  The
usual practice is to have first postgres[_fe].h, followed by the
system headers and finally the internal headers.  That's a nit, but
all the other files do that.

{be,fe}-secure-openssl.c include some exceptions though, as documented
there.

Thoughts?
--
Michael

Commits

  1. Remove unneeded includes of <sys/stat.h>

  2. Remove outdated include

  3. Straighten include order in guc-file.l