Some regression tests for the pg_control_*() functions
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Joe Conway <mail@joeconway.com>
Date: 2022-10-25T05:37:25Z
Lists: pgsql-hackers
Attachments
- controldata-regression-3.patch (text/x-diff) patch
Hi all, As mentioned in [1], there is no regression tests for the SQL control functions: pg_control_checkpoint, pg_control_recovery, pg_control_system and pg_control_init. It would be minimal to check their execution, as of a "SELECT FROM func()", still some validation can be done on its output as long as the test is portable enough (needs transparency for wal_level, commit timestamps, etc.). Attached is a proposal to provide some coverage. Some of the checks could be just removed, like the ones for non-NULL fields, but I have written out everything to show how much could be done. Thoughts? [1]: https://www.postgresql.org/message-id/YzY0iLxNbmaxHpbs@paquier.xyz -- Michael
Commits
-
Add some tests to check the SQL functions of control file
- 1b9cd69c5bdd 16.0 landed