Horton

Re: recovery modules

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Nathan Bossart <nathandbossart@gmail.com>
Date: 2023-02-08T07:23:34Z
Lists: pgsql-hackers 
On Sat, Feb 04, 2023 at 10:14:36AM -0800, Nathan Bossart wrote:
> On Sat, Feb 04, 2023 at 11:59:20AM +0900, Michael Paquier wrote:
>> +   ArchiveModuleCallbacks struct filled with the callback function pointers for
>> This needs a structname markup.
>> 
>> +   can use <literal>state->private_data</literal> to store it.
>> And here it would be structfield.
> 
> fixed

Andres, did you have the change to look at that?  I did look at it,
but it may not address all the points you may have in mind.
--
Michael

Commits

  1. Redesign archive modules

  2. Remove uses of AssertVariableIsOfType() obsoleted by f2b73c8

  3. Rename contrib module basic_archive to basic_wal_module

  4. Refactor code for restoring files via shell commands

  5. Refactor code in charge of running shell-based recovery commands