Horton

Thread

Commits

  1. doc: Fix spelling of option -Dtap_tests for meson

  1. meson doc: Is "-Dtap-tests" a typo?

    Katsuragi Yuta <katsuragiy@oss.nttdata.com> — 2023-02-14T09:06:13Z

    Hi,

The parameter name "-Dtap-tests" in the meson's doc seems to be a typo.
I think "-Dtap_tests" is the correct name.  Attached patch fixes that.

I got an unknown options error by using "-Dtap-tests=enabled". However,
meson_options.txt told me the correct name was "-Dtap_tests".

regards,

-- 
Katsuragi Yuta
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  2. Re: meson doc: Is "-Dtap-tests" a typo?

    Michael Paquier <michael@paquier.xyz> — 2023-02-15T04:44:07Z

    On Tue, Feb 14, 2023 at 09:06:13AM +0000, Katsuragi Yuta wrote:
> The parameter name "-Dtap-tests" in the meson's doc seems to be a typo.
> I think "-Dtap_tests" is the correct name.  Attached patch fixes that.
> 
> I got an unknown options error by using "-Dtap-tests=enabled". However,
> meson_options.txt told me the correct name was "-Dtap_tests".

      <varlistentry id="configure-tap-tests-meson">
-      <term><option>-Dtap-tests={ auto | enabled | disabled }</option></term>
+      <term><option>-Dtap_tests={ auto | enabled | disabled }</option></term>

And meson.build refers to the same term, as of "tap_tests":
# Check whether tap tests are enabled or not
tap_tests_enabled = false
tapopt = get_option('tap_tests')

So you are indeed right.  Nice catch.  Will fix.
--
Michael

  3. Re: meson doc: Is "-Dtap-tests" a typo?

    Katsuragi Yuta <katsuragiy@oss.nttdata.com> — 2023-02-15T06:28:26Z

    On 2023-02-15 13:44, Michael Paquier wrote:
> On Tue, Feb 14, 2023 at 09:06:13AM +0000, Katsuragi Yuta wrote:
>> The parameter name "-Dtap-tests" in the meson's doc seems to be a 
>> typo.
>> I think "-Dtap_tests" is the correct name.  Attached patch fixes that.
>> 
>> I got an unknown options error by using "-Dtap-tests=enabled". 
>> However,
>> meson_options.txt told me the correct name was "-Dtap_tests".
> 
>       <varlistentry id="configure-tap-tests-meson">
> -      <term><option>-Dtap-tests={ auto | enabled | disabled 
> }</option></term>
> +      <term><option>-Dtap_tests={ auto | enabled | disabled 
> }</option></term>
> 
> And meson.build refers to the same term, as of "tap_tests":
> # Check whether tap tests are enabled or not
> tap_tests_enabled = false
> tapopt = get_option('tap_tests')
> 
> So you are indeed right.  Nice catch.  Will fix.
> --
> Michael

Thank you!

regards,

-- 
Katsuragi Yuta
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION