Horton

Re: recovery modules

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2023-02-15T06:38:21Z
Lists: pgsql-hackers 
On Mon, Feb 13, 2023 at 05:02:37PM -0800, Nathan Bossart wrote:
> Sorry for then noise, cfbot alerted me to a missing #include, which I've
> added in v13.

+   basic_archive_context = data->context;
+   Assert(CurrentMemoryContext != basic_archive_context);

So this is what it means to document that we are not in the memory
context we are freeing here.  That seems good enough to me in this
context.  Tracking if one of CurrentMemoryContext's parents is the
memory context that would be deleted would be another thing, but this
does not apply here.

I may tweak a bit the comments, but nothing more.  And I don't think I
have more to add.  Andres, do you have anything you would like to
mention?
--
Michael

Commits

  1. Redesign archive modules

  2. Remove uses of AssertVariableIsOfType() obsoleted by f2b73c8

  3. Rename contrib module basic_archive to basic_wal_module

  4. Refactor code for restoring files via shell commands

  5. Refactor code in charge of running shell-based recovery commands