Re: Some more hackery around cryptohashes (some fixes + SHA1)

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Date: 2020-12-14T03:48:15Z
Lists: pgsql-hackers

Attachments

On Thu, Dec 10, 2020 at 05:07:05PM +0900, Michael Paquier wrote:
> - 0001 is a set of small adjustments for the existing code of
> cryptohashes: some cleanup for MD5 in uuid-ossp, and more importantly
> one fix to call explicit_bzero() on the context data for the fallback
> implementations.  With the existing code, we may leave behind some
> context data.  That could become a problem if somebody has access to
> this area of the memory even when they should not be able to do so,
> something that should not happen, but I see no reason to not play it
> safe and eliminate any traces.  If there are no objections, I'd like
> to apply this part.

This is a nice cleanup, so I have moved ahead and applied it.  A
rebased version of the SHA1 business is attached.
--
Michael

Commits

  1. Introduce SHA1 implementations in the cryptohash infrastructure

  2. Improve some code around cryptohash functions