Horton

Re: please update ps display for recovery checkpoint

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: "Bossart, Nathan" <bossartn@amazon.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Fujii Masao <masao.fujii@oss.nttdata.com>, "k.jamison@fujitsu.com" <k.jamison@fujitsu.com>, Thomas Munro <thomas.munro@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2020-12-11T23:59:51Z
Lists: pgsql-hackers

Attachments

On Fri, Dec 11, 2020 at 06:54:42PM +0000, Bossart, Nathan wrote:
> This approach seems reasonable to me.  I've attached my take on it.

+       /* Reset the process title */
+       set_ps_display("");
I would still recommend to avoid calling set_ps_display() if there is
no need to so as we avoid useless system calls, so I think that this
stuff had better use a common path for the set and reset logic.

My counter-proposal is like the attached, with the set/reset part not
reversed this time, and the code indented :p
--
Michael

Commits

  1. Provide recovery_init_sync_method=syncfs.

  2. Add some checkpoint/restartpoint status to ps display