Incorrect allocation handling for cryptohash functions with OpenSSL
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-12-18T07:35:20Z
Lists: pgsql-hackers
Attachments
- cryptohash-alloc.patch (text/x-diff) patch
- hashfuncs.tar.gz (application/gzip)
Hi all, As of the work done in 87ae9691, I have played with error injections in the code paths using this code, but forgot to count for cases where cascading resowner cleanups are involved. Like other resources (JIT, DSM, etc.), this requires an allocation in TopMemoryContext to make sure that nothing gets forgotten or cleaned up on the way until the resowner that did the cryptohash allocation is handled. Attached is a small extension I have played with by doing some error injections, and a patch. If there are no objections, I would like to commit this fix. Thanks, -- Michael
Commits
-
Fix and simplify some code related to cryptohashes
- 15b824da97af 14.0 landed
-
Fix allocation logic of cryptohash context data with OpenSSL
- 55fe26a4b580 14.0 landed