Re: Refactor MD5 implementations and switch to EVP for OpenSSL
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-12-04T07:05:40Z
Lists: pgsql-hackers
Attachments
- v3-0001-Refactor-MD5-implementations-in-the-tree.patch (text/x-diff) patch v3-0001
On Tue, Nov 10, 2020 at 01:28:09PM +0900, Michael Paquier wrote: > The CF bot has been complaining on Windows and this issue is fixed in > the attached. A refresh of src/tools/msvc for pgcrypto was just > missing. Now that HEAD has the necessary infrastructure to be able to plug in easily new cryptohash routines, here is a rebased patch for MD5. The basics are unchanged. Here is a summary: - The duplication with MD5 implementations (pgcrypto, src/common/) is removed, and gets only used when not building with OpenSSL. - MD5 uses EVP when building with OpenSSL. - Similarly to SHA2, the fallback implementation of MD5 is kept internal to src/common/, with an internal header called md5_int.h. The routines for init, update and final calls are similar to the SHA2 equivalents, making the changes of cryptohash.c straight-forward. The amount of code shaved is still nice: 13 files changed, 641 insertions(+), 775 deletions(-) -- Michael
Commits
-
Refactor MD5 implementations according to new cryptohash infrastructure
- b67b57a966af 14.0 landed
-
Remove md5.c check, add CVS log stamp. Update comments.
- 2ca65f716aee 7.2.1 cited
-
Add new files.
- 957613be18e6 7.2.1 cited