Horton

Re: remove unneeded pstrdup in fetch_table_list

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: "Hou, Zhijie" <houzj.fnst@cn.fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Daniel Gustafsson <daniel@yesql.se>
Date: 2021-01-14T05:10:55Z
Lists: pgsql-hackers 
On Thu, Jan 14, 2021 at 01:17:57AM +0000, Hou, Zhijie wrote:
>>> Thanks. I am thinking to backpatch this even though there is no
>>> problem reported from any production system. What do you think?
>> 
>> No objections from me.
> 
> +1

text_to_cstring() indeed allocates a new string, so the extra
allocation is useless.  FWIW, I don't see much point in poking at
the stable branches here.
--
Michael

Commits

  1. Remove unnecessary pstrdup in fetch_table_list.