Re: Introduce pg_receivewal gzip compression tests

gkokolatos@pm.me

From: gkokolatos@pm.me
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-07-15T07:48:08Z
Lists: pgsql-hackers

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Thursday, July 15th, 2021 at 09:00, Michael Paquier <michael@paquier.xyz> wrote:

> On Wed, Jul 14, 2021 at 02:11:09PM +0000, gkokolatos@pm.me wrote:
>
> > Please find v6 attached.
>
> Thanks. I have spent some time checking this stuff in details, and
> I did some tests on Windows while on it. A run of pgperltidy was
> missing. A second thing is that you added one useless WAL segment
> switch in the ZLIB block, and two at the end, causing the first two in
> the set of three (one in the ZLIB block and one in the final command)
> to be no-ops as they followed a previous WAL switch. The final one
> was not needed as no WAL is generated after that.
>

Thank you for the work and comments.

> And applied. Let's see if the buildfarm has anything to say. Perhaps
> this will even catch some bugs that pre-existed.

Let us hope that it will prevent some bugs from happening.

Cheers,
//Georgios

> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Michael



Commits

  1. Re-enable TAP tests of pg_receivewal for ZLIB on Windows

  2. Fix some issues with WAL segment opening for pg_receivewal --compress

  3. Disable tests involving ZLIB on Windows for pg_receivewal

  4. Fix portability issue with gzip in TAP test of pg_receivewal

  5. Add TAP tests for ZLIB compression for pg_receivewal