RE: [PATCH] Preserve replication origin OIDs in pg_upgrade
Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: 'Ajin Cherian' <itsajin@gmail.com>, vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-05-07T07:47:01Z
Lists: pgsql-hackers
Dear Ajin, Thanks for updating the patch. Let me share my two high-level comments. 1. Can you clarify the policy for backward compatibility? In other words, should we preserve subscription OIDs and migrate replication origins from PG19- instances? Similar commits 9a17be1 and 29d0a77 did not allow migrating objects from released versions. 2. I found that other objects use global variables like binary_upgrade_next_xxx to specify the next OID. Can we follow the manner even for replication origins? Or it's not a good approach because of some reasons? BTW, cfbot got angry with your patch. Best regards, Hayato Kuroda FUJITSU LIMITED