RE: Design of pg_stat_subscription_workers vs pgstats

Takamichi Osumi (Fujitsu) <osumi.takamichi@fujitsu.com>

From: "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>
To: 'Masahiko Sawada' <sawada.mshk@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Andres Freund <andres@anarazel.de>, "David G. Johnston" <david.g.johnston@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-02-23T01:13:45Z
Lists: pgsql-hackers
On Tuesday, February 22, 2022 11:47 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> On Tue, Feb 22, 2022 at 9:22 PM osumi.takamichi@fujitsu.com
> <osumi.takamichi@fujitsu.com> wrote:
> > (4) doc/src/sgml/monitoring.sgml
> >
> >       <row>
> >        <entry role="catalog_table_entry"><para
> role="column_definition">
> > -       <structfield>last_error_time</structfield> <type>timestamp with
> time zone</type>
> > +       <structfield>sync_error_count</structfield> <type>uint8</type>
> >        </para>
> >        <para>
> > -       Last time at which this error occurred
> > +       Number of times the error occurred during the initial data
> > + copy
> >        </para></entry>
> >
> > I supposed it might be better to use "initial data sync"
> > or "initial data synchronization", rather than "initial data copy".
> 
> "Initial data synchronization" sounds like the whole table synchronization
> process including COPY and applying changes to catch up. But
> sync_error_count is incremented only during COPY so I used "initial data copy".
> What do you think?
Okay. Please keep it as is.


Best Regards,
	Takamichi Osumi

Commits

  1. Reconsider pg_stat_subscription_workers view.

  2. Add a view to show the stats of subscription workers.