Horton

Thread

Commits

  1. Fix typo in CREATE PUBLICATION reference page

  1. possible typo for CREATE PUBLICATION description

    Takamichi Osumi (Fujitsu) <osumi.takamichi@fujitsu.com> — 2022-10-13T07:16:39Z

    Hi,


I noticed a possible typo in the doc for create publication.
This applies to PG15 as well.
Kindly have a look at the attached patch for it.


Best Regards,
	Takamichi Osumi

  2. Re: possible typo for CREATE PUBLICATION description

    Peter Smith <smithpb2250@gmail.com> — 2022-10-13T07:26:16Z

    On Thu, Oct 13, 2022 at 6:16 PM osumi.takamichi@fujitsu.com
<osumi.takamichi@fujitsu.com> wrote:
>
> Hi,
>
>
> I noticed a possible typo in the doc for create publication.
> This applies to PG15 as well.
> Kindly have a look at the attached patch for it.
>
>

Your typo correction LGTM.

FWIW, maybe other parts of that paragraph can be tidied too. e.g. The
words "actually" and "So" didn't seem needed IMO.

~

BEFORE
For an INSERT ... ON CONFLICT command, the publication will publish
the operation that actually results from the command. So depending on
the outcome, it may be published as either INSERT or UPDATE, or it may
not be published at all.

SUGGESTION
For an INSERT ... ON CONFLICT command, the publication will publish
the operation that results from the command. Depending on the outcome,
it may be published as either INSERT or UPDATE, or it may not be
published at all.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

  3. Re: possible typo for CREATE PUBLICATION description

    Alvaro Herrera <alvherre@alvh.no-ip.org> — 2022-10-13T11:37:58Z

    Hello

On 2022-Oct-13, osumi.takamichi@fujitsu.com wrote:

> I noticed a possible typo in the doc for create publication.
> This applies to PG15 as well.
> Kindly have a look at the attached patch for it.

Yeah, looks good.  It actually applies all the way back to 10, so I
pushed it to all branches.  I included Peter's wording changes as well.

Thanks

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Ellos andaban todos desnudos como su madre los parió, y también las mujeres,
aunque no vi más que una, harto moza, y todos los que yo vi eran todos
mancebos, que ninguno vi de edad de más de XXX años" (Cristóbal Colón)

  4. RE: possible typo for CREATE PUBLICATION description

    Takamichi Osumi (Fujitsu) <osumi.takamichi@fujitsu.com> — 2022-10-13T12:02:09Z

    Hi, Alvaro-san


On Thursday, October 13, 2022 8:38 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> On 2022-Oct-13, osumi.takamichi@fujitsu.com wrote:
> 
> > I noticed a possible typo in the doc for create publication.
> > This applies to PG15 as well.
> > Kindly have a look at the attached patch for it.
> 
> Yeah, looks good.  It actually applies all the way back to 10, so I pushed it to
> all branches.  I included Peter's wording changes as well.
> 
> Thanks
You are right and thank you so much for taking care of this !


Best Regards,
	Takamichi Osumi