RE: Support tab completion for upper character inputs in psql

tanghy.fnst@fujitsu.com <tanghy.fnst@fujitsu.com>

From: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>

To: Japin Li <japinli@hotmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Laurenz Albe <laurenz.albe@cybertec.at>, "smithpb2250@gmail.com" <smithpb2250@gmail.com>, "david.zhang@highgo.ca" <david.zhang@highgo.ca>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2022-01-07T05:17:21Z

Lists: pgsql-hackers

Attachments

v11-0001-Support-tab-completion-with-a-query-result-for-u.patch (application/octet-stream) patch v11-0001

On Friday, January 7, 2022 1:08 PM, Japin Li <japinli@hotmail.com> wrote:
> +/*
> + * pg_string_tolower - Fold a string to lower case if the string is not quoted
> + * and only contains ASCII characters.
> + * For German/Turkish etc text, no change will be made.
> + *
> + * The returned value has to be freed.
> + */
> +static char *
> +pg_string_tolower_if_ascii(const char *text)
> +{
> 
> s/pg_string_tolower/pg_string_tolower_if_ascii/ for comments.
> 

Thanks for your review.
Comment fixed in the attached V11 patch.

Regards,
Tang

Commits

Fix minor memory leaks in psql's tab completion.
- 90474c16a7d2 16.0 landed
- 00cf40328a31 15.0 landed
Further tweaks for psql's new tab-completion logic.
- f0cd9097cfac 15.0 landed
Treat case of tab-completion keywords a bit more carefully.
- 020258fbd30d 15.0 landed
psql: improve tab-complete's handling of variant SQL names.
- 02b8048ba5dc 15.0 landed
Make PQcancel use the PGconn's tcp_user_timeout and keepalives settings.
- 5987feb70b5b 15.0 cited
Use a WaitLatch for vacuum/autovacuum sleeping
- 4753ef37e0ed 14.0 cited