Horton

RE: [PoC] pg_upgrade: allow to upgrade publisher node

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

View thread View on postgr.es
From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: 'Masahiko Sawada' <sawada.mshk@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Bruce Momjian <bruce@momjian.us>, Julien Rouhaud <rjuju123@gmail.com>, vignesh C <vignesh21@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Date: 2023-08-21T13:04:06Z
Lists: pgsql-hackers 
Dear Sawada-san,

Thank you for reviewing! New patch set can be available in [1].

> 
> 0001:
> 
> Do we need regression tests to make sure that the slot's
> confirmed_flush_lsn matches the LSN of the latest shutdown_checkpoint
> record?

Added. I wondered the location of the test, but put on
test_decoding/t/002_always_persist.pl.

> 0002:
> 
> +   <step>
> +    <title>Prepare for publisher upgrades</title>
> +
> 
> Should this step be done before "8. Stop both servers" as it might
> require to disable subscriptions and to drop 'lost' replication slots?

Right, moved.

> Why is there no explanation about the slots' confirmed_flush_lsn check
> as prerequisites?

Added.

[1]: https://www.postgresql.org/message-id/TYCPR01MB5870B5C0FE0C61CD04CBD719F51EA%40TYCPR01MB5870.jpnprd01.prod.outlook.com

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

  1. Fix issues in binary_upgrade_logical_slot_has_caught_up().

  2. Fix a random failure in 003_logical_slots.pl.

  3. Fix a test in 003_logical_slots.

  4. Fix uninitialized slot array access during the upgrade.

  5. Fix the test 003_logical_slots.

  6. Commit b195e6d482 forgot to update meson.build.

  7. Use shorter file names in the upgrade logical slots test.

  8. Migrate logical slots to the new node during an upgrade.

  9. Flush logical slots to disk during a shutdown checkpoint if required.

  10. Prevent possibility of panics during shutdown checkpoint.