Horton

RE: [PoC] pg_upgrade: allow to upgrade publisher node

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

View thread View on postgr.es
From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, 'Peter Smith' <smithpb2250@gmail.com>, Bruce Momjian <bruce@momjian.us>, Julien Rouhaud <rjuju123@gmail.com>, vignesh C <vignesh21@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>
Date: 2023-08-21T13:05:57Z
Lists: pgsql-hackers 
Dear Hou,

Thank you for reviewing! The patch can be available in [1].

> 1.
> 
> +check_for_lost_slots(ClusterInfo *cluster)
> +{
> +	int			i,
> +				ntups,
> +				i_slotname;
> +	PGresult   *res;
> +	DbInfo	   *active_db = &cluster->dbarr.dbs[0];
> +	PGconn	   *conn = connectToServer(cluster, active_db->db_name);
> +
> +	/* logical slots can be migrated since PG17. */
> +	if (GET_MAJOR_VERSION(cluster->major_version) <= 1600)
> +		return;
> 
> I think we should build connection after this check, otherwise the connection
> may be left open after returning.

Fixed.

> 2.
> +check_for_confirmed_flush_lsn(ClusterInfo *cluster)
> +{
> +	int			i,
> +				ntups,
> +				i_slotname;
> +	PGresult   *res;
> +	DbInfo	   *active_db = &cluster->dbarr.dbs[0];
> +	PGconn	   *conn = connectToServer(cluster, active_db->db_name);
> +
> +	/* logical slots can be migrated since PG17. */
> +	if (GET_MAJOR_VERSION(cluster->major_version) <= 1600)
> +		return;
> 
> Same as above.

Fixed.

> 3.
> +				if
> (GET_MAJOR_VERSION(cluster->major_version) >= 17)
> +				{
> 
> I think you mean 1700 here.

Right, fixed.

> 4.
> +					p = strpbrk(p,
> "01234567890ABCDEF");
> +
> +					/*
> +					 * Upper and lower part of LSN must
> be read separately
> +					 * because it is reported as %X/%X
> format.
> +					 */
> +					upper_lsn = strtoul(p, &slash, 16);
> +					lower_lsn = strtoul(++slash, NULL,
> 16);
> 
> Maybe we'd better add a sanity check after strpbrk like "if (p == NULL ||
> strlen(p) <= 1)" to be consistent with other similar code.

Added.

[1]: https://www.postgresql.org/message-id/TYCPR01MB5870B5C0FE0C61CD04CBD719F51EA%40TYCPR01MB5870.jpnprd01.prod.outlook.com

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

  1. Fix issues in binary_upgrade_logical_slot_has_caught_up().

  2. Fix a random failure in 003_logical_slots.pl.

  3. Fix a test in 003_logical_slots.

  4. Fix uninitialized slot array access during the upgrade.

  5. Fix the test 003_logical_slots.

  6. Commit b195e6d482 forgot to update meson.build.

  7. Use shorter file names in the upgrade logical slots test.

  8. Migrate logical slots to the new node during an upgrade.

  9. Flush logical slots to disk during a shutdown checkpoint if required.

  10. Prevent possibility of panics during shutdown checkpoint.