RE: speed up a logical replica setup

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

To: 'Euler Taveira' <euler@eulerto.com>, Tomas Vondra <tomas.vondra@enterprisedb.com>

Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, Michael Paquier <michael@paquier.xyz>, Peter Eisentraut <peter@eisentraut.org>, Andres Freund <andres@anarazel.de>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Fabrízio de Royes Mello <fabriziomello@gmail.com>, vignesh C <vignesh21@gmail.com>

Date: 2024-03-13T07:47:52Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pg_createsubscriber: Remove obsolete comment
- 71795d1cb41b 17.0 landed
- 1330843bb78e 18.0 landed
pg_createsubscriber: Fix an unpredictable recovery wait time.
- e5ba6a5ab62c 17.0 landed
- 03b08c8f5f3e 18.0 landed
Fix unstable test in 040_pg_createsubscriber.
- ae4e072bad5f 17.0 landed
- 9fd8b331dfe1 18.0 landed
Fix the testcase introduced in commit 81d20fbf7a.
- ae395f0f7edb 18.0 landed
- 14387ab06503 17.0 landed
Further weaken new pg_createsubscriber test on Windows.
- 55c309fc5b08 17.0 landed
- a1333ec048fb 18.0 landed
Temporarily(?) weaken new pg_createsubscriber test on Windows.
- 54508209178b 17.0 landed
Make pg_createsubscriber warn if publisher has two-phase commit enabled.
- 917754557cc0 17.0 landed
Make pg_createsubscriber more wary about quoting connection parameters.
- b3f5ccebd79d 17.0 landed
pg_createsubscriber: Remove failover replication slots on subscriber
- 81d20fbf7a03 17.0 landed
pg_createsubscriber: Remove replication slot check on primary
- b96391382626 17.0 landed
pg_createsubscriber: Only --recovery-timeout controls the end of recovery process
- 04c8634c0c4d 17.0 landed
pg_createsubscriber: creates a new logical replica from a standby server
- d44032d01463 17.0 landed
Add some const decorations
- 48018f1d8c12 17.0 landed
Add option force_initdb to PostgreSQL::Test::Cluster:init()
- ff9e1e764fcc 17.0 cited
Remove MSVC scripts
- 1301c80b2167 17.0 cited

Attachments

v28-0001-pg_createsubscriber-creates-a-new-logical-replic.patch (application/octet-stream) patch v28-0001
v28-0002-Use-last-replication-slot-position-as-replicatio.patch (application/octet-stream) patch v28-0002
v28-0003-port-replace-int-with-string.patch (application/octet-stream) patch v28-0003
v28-0004-fix.patch (application/octet-stream) patch v28-0004

Dear Euler,

Thanks for updating the patch! I have not reviewed yet, but cfbot did not
accept your patch [1]. It seems that you missed updating the windows part
in 0003 patch:

```
#if !defined(WIN32)
-       sub_base_conninfo = psprintf("host=%s port=%u user=%s fallback_application_name=%s",
+       sub_base_conninfo = psprintf("host=%s port=%s user=%s fallback_application_name=%s",
                                                                 opt.socket_dir, opt.sub_port, opt.sub_username, progname);
 #else                                                  /* WIN32 */
        sub_base_conninfo = psprintf("port=%u user=%s fallback_application_name=%s"
```

Since the change is quite trivial, I felt no need to update the versioning.
PSA the new set to keep the cfbot quiet. These could pass tests on my CI.

[1]:  https://cirrus-ci.com/build/5253379782344704

Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/global/