Horton

RE: [PoC] pg_upgrade: allow to upgrade publisher node

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

View thread View on postgr.es
From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Bruce Momjian <bruce@momjian.us>, Julien Rouhaud <rjuju123@gmail.com>, vignesh C <vignesh21@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, 'Dilip Kumar' <dilipbalaut@gmail.com>
Date: 2023-09-12T11:50:35Z
Lists: pgsql-hackers 
Dear Hou,

Thank you for reviewing!

> 1.
> 
>  #include "access/transam.h"
>  #include "catalog/pg_language_d.h"
> +#include "fe_utils/string_utils.h"
>  #include "pg_upgrade.h"
> 
> It seems we don't need this head file anymore.

Removed.

> 2.
> +		if (*invalidated && SlotIsLogical(s) && IsBinaryUpgrade)
> +			elog(ERROR, "Replication slots must not be invalidated
> during the upgrade.");
> 
> I think normally the first letter is lowercase, and we can avoid the period.

Right, fixed. Also, a period is removed based on the rule. Apart from other detailed
messages, this just reports what happened.

```
        if (nslots_on_old > max_replication_slots)
                pg_fatal("max_replication_slots (%d) must be greater than or equal to the number of "
-                                "logical replication slots (%d) on the old cluster.",
+                                "logical replication slots (%d) on the old cluster",
                                 max_replication_slots, nslots_on_old);
```

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

  1. Fix issues in binary_upgrade_logical_slot_has_caught_up().

  2. Fix a random failure in 003_logical_slots.pl.

  3. Fix a test in 003_logical_slots.

  4. Fix uninitialized slot array access during the upgrade.

  5. Fix the test 003_logical_slots.

  6. Commit b195e6d482 forgot to update meson.build.

  7. Use shorter file names in the upgrade logical slots test.

  8. Migrate logical slots to the new node during an upgrade.

  9. Flush logical slots to disk during a shutdown checkpoint if required.

  10. Prevent possibility of panics during shutdown checkpoint.