RE: Perform streaming logical transactions by background workers and parallel apply

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

To: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, shveta malik <shveta.malik@gmail.com>, "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Peter Smith <smithpb2250@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>

Date: 2023-01-26T03:36:57Z

Lists: pgsql-hackers

Dear Hou,

Thank you for updating the patch! Followings are comments.

1. config.sgml

```
+        the changes till logical_decoding_work_mem is reached. It can also be
```

I think it should be sandwiched by <varname>.

2. config.sgml

```
+        On the publisher side, <varname>logical_replication_mode</varname> allows
+        allows streaming or serializing changes immediately in logical decoding.
```

Typo "allows allows" -> "allows"

3. test general

You confirmed that the leader started to serialize changes, but did not ensure the endpoint.
IIUC the parallel apply worker exits after applying serialized changes, and it is not tested yet.
Can we add polling the log somewhere?


4. 015_stream.pl

```
+is($result, qq(15000), 'all changes are replayed from file')
```

The statement may be unclear because changes can be also replicated when streaming = on.
How about: "parallel apply worker replayed all changes from file"?


Best Regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix invalid memory access during the shutdown of the parallel apply worker.
- 3d144c6c8602 16.0 landed
Fix assertion failure in apply worker.
- de63f8dadee4 16.0 landed
Use elog to report unexpected action in handle_streamed_transaction().
- 781ac42d43ab 16.0 landed
Use appropriate wait event when sending data in the apply worker.
- d9d7fe68d35e 16.0 landed
Allow the logical_replication_mode to be used on the subscriber.
- 9f2213a7c575 16.0 landed
Rename GUC logical_decoding_mode to logical_replication_mode.
- 1e8b61735cfb 16.0 landed
Display the leader apply worker's PID for parallel apply workers.
- d540a02a724b 16.0 landed
Improve the code to decide and process the apply action.
- c981d9145dea 16.0 landed
Document the newly added wait events added by commit 216a784829.
- cd06ccd78fcf 16.0 landed
Perform apply of large transactions by parallel workers.
- 216a784829c2 16.0 landed
Wake up a subscription's replication worker processes after DDL.
- c6e1f62e2cee 16.0 cited
Add copyright notices to meson files
- 8284cf5f746f 16.0 cited
Better document logical replication parameters
- a8500750ca0a 16.0 cited
Add a common function to generate the origin name.
- 776e1c8a5d14 16.0 cited
Harmonize parameter names in storage and AM code.
- bfcf1b34805f 16.0 cited
Avoid using list_length() to test for empty list.
- efd0c16becbf 16.0 cited
Improve two comments related to a boolean DefElem's value
- 8445f5a21d40 16.0 cited
Fix partition table's REPLICA IDENTITY checking on the subscriber.
- 26b3455afaa9 15.0 cited
Fix data inconsistency between publisher and subscriber.
- b7658c24c7c1 15.0 cited
Fix cache look-up failures while applying changes in logical replication.
- 5a97b1325453 15.0 cited