Horton

RE: doc: add missing "id" attributes to extension packaging page

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

View thread View on postgr.es
From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: 'Brar Piening' <brar@gmx.de>, Peter Smith <smithpb2250@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, "Karl O. Pinc" <kop@karlpinc.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, vignesh C <vignesh21@gmail.com>, Ian Lawrence Barwick <barwick@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-03-29T04:52:56Z
Lists: pgsql-hackers 
Dear my comrade Brar,

> Thanks, I actually was not aware of this.
> 
> Also, kudos for capturing the missing id and advocating for consistency
> regarding ids even before this is actively enforced. This nurtures my
> optimism that consistency might actually be achieveable without
> everybody getting angry at me because my patch will enforce it.
> 
> Regarding the overlap, I currently try to make it as easy as possible
> for a potential committer and I'm happy to rebase my patch upon request
> or if Kuroda-san's patch gets applied first.

FYI - my patch is pushed [1]. Could you please rebase your patch?
I think it's ok to just remove changes from logical-replication.sgml, ref/alter_subscription.sgml,
and ref/create_subscription.sgml.

[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=de5a47af2d8003dee123815bb7e58913be9a03f3

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

  1. doc: Make HTML ids discoverable

  2. Add missing XML ID attribute

  3. postgres_fdw: Add support for parallel abort.

  4. Add missing XML ID attributes

  5. Add XML ID attributes to create_subscription.sgml.

  6. Stop recommending auto-download of DTD files, and indeed disable it.

  7. Doc: add XML ID attributes to <sectN> and <varlistentry> tags.

  8. Allow left join removals and unique joins on partitioned tables

  9. Improve GIN cost estimation