Horton
Menu

RE: Perform streaming logical transactions by background workers and parallel apply

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

View thread
From: "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>
To: "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, Peter Smith <smithpb2250@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-09-27T06:32:13Z
Lists: pgsql-hackers 
Dear Wang,

Followings are comments for your patchset.

====
0001


01. launcher.c - logicalrep_worker_stop_internal()

```
+
+       Assert(LWLockHeldByMe(LogicalRepWorkerLock));
+
```

I think it should be Assert(LWLockHeldByMeInMode(LogicalRepWorkerLock, LW_SHARED))
because the lock is released one and acquired again as LW_SHARED.
If newer function has been acquired lock as LW_EXCLUSIVE and call logicalrep_worker_stop_internal(),
its lock may become weaker after calling it.

02. launcher.c - apply_handle_stream_start()

```
+                       /*
+                        * Notify handle methods we're processing a remote in-progress
+                        * transaction.
+                        */
+                       in_streamed_transaction = true;
 
-               MyLogicalRepWorker->stream_fileset = palloc(sizeof(FileSet));
-               FileSetInit(MyLogicalRepWorker->stream_fileset);
+                       /*
+                        * Start a transaction on stream start, this transaction will be
+                        * committed on the stream stop unless it is a tablesync worker in
+                        * which case it will be committed after processing all the
+                        * messages. We need the transaction for handling the buffile,
+                        * used for serializing the streaming data and subxact info.
+                        */
+                       begin_replication_step();
```

Previously in_streamed_transaction was set after the begin_replication_step(),
but the ordering is modified. Maybe we don't have to modify it if there is no particular reason.

03. launcher.c - apply_handle_stream_stop()

```
+                       /* Commit the per-stream transaction */
+                       CommitTransactionCommand();
+
+                       /* Reset per-stream context */
+                       MemoryContextReset(LogicalStreamingContext);
+
+                       pgstat_report_activity(STATE_IDLE, NULL);
+
+                       in_streamed_transaction = false;
```

Previously in_streamed_transaction was set after the MemoryContextReset(), but the ordering is modified.
Maybe we don't have to modify it if there is no particular reason.

04. applyparallelworker.c - LogicalParallelApplyLoop()

```
+               shmq_res = shm_mq_receive(mqh, &len, &data, false);
...
+               if (ConfigReloadPending)
+               {
+                       ConfigReloadPending = false;
+                       ProcessConfigFile(PGC_SIGHUP);
+               }
```


Here the parallel apply worker waits to receive messages and after dispatching it ProcessConfigFile() is called.
It means that .conf will be not read until the parallel apply worker receives new messages and apply them.

It may be problematic when users change log_min_message to debugXXX for debugging but the streamed transaction rarely come.
They expected that detailed description appears on the log from next streaming chunk, but it does not.

This does not occur in leader worker when it waits messages from publisher, because it uses libpqrcv_receive(), which works asynchronously.

I 'm not sure whether it should be documented that the evaluation of GUCs may be delayed, how do you think?

===
0004

05. logical-replication.sgml

```
...
In that case, it may be necessary to change the streaming mode to on or off and cause
the same conflicts again so the finish LSN of the failed transaction will be written to the server log.
 ...
```

Above sentence is added by 0001, but it is not modified by 0004.
Such transactions will be retried as streaming=on mode, so some descriptions related with it should be added.


Best Regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix invalid memory access during the shutdown of the parallel apply worker.

  2. Fix assertion failure in apply worker.

  3. Use elog to report unexpected action in handle_streamed_transaction().

  4. Use appropriate wait event when sending data in the apply worker.

  5. Allow the logical_replication_mode to be used on the subscriber.

  6. Rename GUC logical_decoding_mode to logical_replication_mode.

  7. Display the leader apply worker's PID for parallel apply workers.

  8. Improve the code to decide and process the apply action.

  9. Document the newly added wait events added by commit 216a784829.

  10. Perform apply of large transactions by parallel workers.

  11. Wake up a subscription's replication worker processes after DDL.

  12. Add copyright notices to meson files

  13. Better document logical replication parameters

  14. Add a common function to generate the origin name.

  15. Harmonize parameter names in storage and AM code.

  16. Avoid using list_length() to test for empty list.

  17. Improve two comments related to a boolean DefElem's value

  18. Fix partition table's REPLICA IDENTITY checking on the subscriber.

  19. Fix data inconsistency between publisher and subscriber.

  20. Fix cache look-up failures while applying changes in logical replication.