RE: Conflict detection and logging in logical replication

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>

To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>

Cc: shveta malik <shveta.malik@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Dilip Kumar <dilipbalaut@gmail.com>, Jan Wieck <jan@wi3ck.info>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>

Date: 2024-08-07T04:01:28Z

Lists: pgsql-hackers

Attachments

fixes_for_v11.patch (application/octet-stream) patch v11

Dear Hou,

> 
> Here is the V11 patch set which addressed above and Kuroda-san[1] comments.
>

Thanks for updating the patch. I read 0001 again and I don't have critical comments for now.
I found some cosmetic issues (e.g., lines should be shorter than 80 columns) and
attached the fix patch. Feel free to include in the next version.
	
Best regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

Rename the conflict types for the origin differ cases.
- 640178c92e3f 18.0 landed
Doc: explain the log format of logical replication conflicts.
- edcb71258504 18.0 landed
Log the conflicts while applying changes in logical replication.
- 9758174e2e5c 18.0 landed
Avoid duplicate table scans for cross-partition updates during logical replication.
- a67da49e1d98 18.0 cited