RE: BEFORE UPDATE trigger on postgres_fdw table not work

shohei.mochizuki@toshiba.co.jp

From: <shohei.mochizuki@toshiba.co.jp>
To: <etsuro.fujita@gmail.com>
Cc: <Langote_Amit_f8@lab.ntt.co.jp>, <tgl@sss.pgh.pa.us>, <pgsql-hackers@postgresql.org>
Date: 2019-06-13T11:16:13Z
Lists: pgsql-hackers
Fujita-san,

> From: Etsuro Fujita [mailto:etsuro.fujita@gmail.com]
> 
> Mochizuki-san,
> 
> On Wed, Jun 12, 2019 at 6:08 PM <shohei.mochizuki@toshiba.co.jp> wrote:
> > > On Mon, Jun 10, 2019 at 9:04 PM Etsuro Fujita
> > > <etsuro.fujita@gmail.com>
> > > wrote:
> > > > I'll look into the patch more closely tomorrow.
> > >
> > > I did that, but couldn't find any issue about the patch.  Here is an
> > > updated version of the patch.  Changes are:
> > >
> > > * Reworded the comments a bit in postgresPlanFoereignModify the
> > > original patch modified
> > > * Added the commit message
> 
> > I think your wording is more understandable than my original patch.
> 
> Great!  I've pushed the patch after updating the comment as proposed by
> Amit-san yesterday, and adding a regression test case checking EXPLAIN
> because otherwise we wouldn't have any EXPLAIN results in v9.4.
> 
> Thanks for the report and fix!

Thanks for the commit!

--
Shohei Mochizuki

Commits

  1. postgres_fdw: Account for triggers in non-direct remote UPDATE planning.

  2. Offer triggers on foreign tables.