Horton

RE: libpq debug log

tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>

View thread View on postgr.es
From: "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>
To: "iwata.aya@fujitsu.com" <iwata.aya@fujitsu.com>, 'Kyotaro Horiguchi' <horikyota.ntt@gmail.com>
Cc: "alvherre@alvh.no-ip.org" <alvherre@alvh.no-ip.org>, "tgl@sss.pgh.pa.us" <tgl@sss.pgh.pa.us>, "k.jamison@fujitsu.com" <k.jamison@fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-03-18T08:51:02Z
Lists: pgsql-hackers 
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
> + pqTraceOutputR(const char *message, FILE *f)
> + {
> + 	int	cursor = 0;
> +
> + 	pqTraceOutputInt32(message, &cursor, f);
> 
> I don't understand the reason for spliting message and &cursor here.
> 
> + pqTraceOutputR(const char *message, FILE *f)
> + {
> + 	char *p = message;
> +
> + 	pqTraceOutputInt32(&p, f);
> 
> works well.

Yes, that would also work.  But I like the separate cursor + fixed starting point here, probably because it's sometimes confusing to see the pointer value changed inside functions.  (And a pointer itself is an allergy for some people, not to mention a pointer to ointer...)  Also, libpq uses cursors for network I/O buffers.  So, I think the patch can be as it is now.


> +static void
> +pqTraceOutputT(const char *message, int end, FILE *f)
> +{
> +	int	cursor = 0;
> +	int nfields;
> +	int	i;
> +
> +	nfields = pqTraceOutputInt16(message, &cursor, f);
> +
> +	for (i = 0; i < nfields; i++)
> +	{
> +		pqTraceOutputString(message, &cursor, end, f);
> +		pqTraceOutputInt32(message, &cursor, f);
> +		pqTraceOutputInt16(message, &cursor, f);
> +		pqTraceOutputInt32(message, &cursor, f);
> +		pqTraceOutputInt16(message, &cursor, f);
> +		pqTraceOutputInt32(message, &cursor, f);
> +		pqTraceOutputInt16(message, &cursor, f);
> +	}
> +}
> 
> I didn't looked closer, but lookong the usage of the variable "end",
> something's wrong in the function.

Ah, end doesn't serve any purpose.  I guess the compiler emitted a warning "end is not used".  I think end can be removed.



	Regards
Takayuki Tsunakawa}

Commits

  1. Rename PQtraceSetFlags() to PQsetTraceFlags().

  2. Suppress length of Notice/Error msgs in PQtrace regress mode

  3. Strip file names reported in error messages on Windows, too.

  4. Fix setvbuf()-induced crash in libpq_pipeline

  5. libpq_pipeline: Must strdup(optarg) to avoid crash

  6. Remove setvbuf() call from PQtrace()

  7. Initialize conn->Pfdebug to NULL when creating a connection

  8. Disable force_parallel_mode in libpq_pipeline

  9. libpq_pipeline: add PQtrace() support and tests

  10. Improve PQtrace() output format

  11. Re-simplify management of inStart in pqParseInput3's subroutines.