RE: [POC] Fast COPY FROM command for the table with foreign partitions

tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>

From: "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>

To: 'Justin Pryzby' <pryzby@telsasoft.com>

Cc: Amit Langote <amitlangote09@gmail.com>, Andrey Lepikhov <a.lepikhov@postgrespro.ru>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Alexey Kondratov <a.kondratov@postgrespro.ru>, Michael Paquier <michael@paquier.xyz>, Ashutosh Bapat <ashutosh.bapat@2ndquadrant.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Etsuro Fujita <etsuro.fujita@gmail.com>, PostgreSQL-Dev <pgsql-hackers@postgresql.org>, Tomas Vondra <tomas.vondra@enterprisedb.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>

Date: 2021-03-04T02:24:24Z

Lists: pgsql-hackers

Attachments

v17-0001-Fast-COPY-FROM-into-the-foreign-or-sharded-table.patch (application/octet-stream) patch v17-0001

	From: Justin Pryzby <pryzby@telsasoft.com>
> Find attached some language fixes.

Thanks a lot!  (I wish there will be some tool like "pgEnglish" that corrects English in code comments and docs.)


> |/* Do this to ensure we've pumped libpq back to idle state */
> 
> I don't know why you mean by "pumped"?

I changed it to "have not gotten extra results" to match the error message.


> The CopySendEndOfRow "case COPY_CALLBACK:" should have a "break;"

Added.

> This touches some of the same parts as my "bulk insert" patch:
> https://commitfest.postgresql.org/32/2553/

My colleague will be reviewing it.


Regards
Takayuki Tsunakawa

Commits

Allow batch insertion during COPY into a foreign table.
- 97da48246d34 16.0 landed
postgres_fdw: Disable batch insertion when there are WCO constraints.
- 82593b9a3d5f 16.0 cited
Enforce foreign key correctly during cross-partition updates
- ba9a7e392171 15.0 cited
Fix permission checks on constraint violation errors on partitions.
- 6214e2b22804 14.0 cited
Fix compilation of uuid-ossp
- 525e60b74299 14.0 cited