RE: [Patch] Optimize dropping of relation buffers using dlist

tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>

From: "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>

To: 'Thomas Munro' <thomas.munro@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>

Cc: "k.jamison@fujitsu.com" <k.jamison@fujitsu.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, "jankirk.jamison@gmail.com" <jankirk.jamison@gmail.com>

Date: 2021-03-12T05:26:02Z

Lists: pgsql-hackers

Attachments

v1-0001-Fix-overflow-when-counting-the-number-of-buffers-.patch (application/octet-stream) patch v1-0001

From: Thomas Munro <thomas.munro@gmail.com>
> > uint64
> 
> +1

Thank you, the patch is attached (we tend to forget how large our world is... 64-bit)  We're sorry to cause you trouble.

	
Regards
Takayuki Tsunakawa

Commits

Fix size overflow in calculation introduced by commits d6ad34f3 and bea449c6.
- 519e4c9ee21a 14.0 landed
Optimize DropRelFileNodesAllBuffers() for recovery.
- bea449c635c0 14.0 landed
Optimize DropRelFileNodeBuffers() for recovery.
- d6ad34f3410f 14.0 landed
Cache smgrnblocks() results in recovery.
- c5315f4f4484 14.0 cited
Add a check to prevent overwriting valid data if smgrnblocks() gives a
- ffae5cc5a602 8.2.0 cited