RE: Wrong statistics for size of XLOG_SWITCH during pg_waldump.
shinya11.kato@nttdata.com
From: <Shinya11.Kato@nttdata.com>
To: <david@pgmasters.net>, <Shinya11.Kato@nttdata.com>, <movead.li@highgo.ca>
Cc: <pgsql-hackers@postgresql.org>, <andres@anarazel.de>,
<michael@paquier.xyz>, <ahsan.hadi@highgo.ca>,
<horikyota.ntt@gmail.com>
Date: 2021-03-19T06:06:47Z
Lists: pgsql-hackers
>>>But 0 value maybe looks strange, so in current version I show it like >below: >>>Type N (%) Record size (%) FPI size (%) Combined size (%) >>>---- - --- ----------- --- -------- --- ------------- --- ... >>>XLOG/SWITCH_JUNK - ( -) 11006248 ( 72.26) - ( -) 11006248 ( 65.78) >>>Transaction/COMMIT 10 ( 0.03) 340 ( 0.00) 0 ( 0.00) 340 ( 0.00) >> >> I just wanted to know why the "count" and "fpi_len" fields 0 are. >> So, it would be nice to have 0 values. Sorry for confusing you. > >Kato, it's not clear to me if you were asking for - to be changed back to 0? > >You marked the patch as Ready for Committer so I assume not, but it would be >better to say clearly that you think this patch is ready for a committer to look at. Yes, I don't think it needs to be changed back to 0. I think this patch is ready for a committer to look at. Regards, Shinya Kato
Commits
-
pg_waldump: Fix bug in per-record statistics.
- e73068b0710b 9.6.22 landed
- 5386a8506d7d 10.17 landed
- 4a2627c41cfe 11.12 landed
- 4220e06f4c0c 12.7 landed
- 34279fd4fabd 13.3 landed
- 51893c846350 14.0 landed