RE: BUG #15858: could not stat file - over 4GB

wangsh.fnst@fujitsu.com <wangsh.fnst@fujitsu.com>

From: "wangsh.fnst@fujitsu.com" <wangsh.fnst@fujitsu.com>
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>, Emil Iggland <emil@iggland.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-25T06:39:14Z
Lists: pgsql-bugs, pgsql-hackers
Thank you for sharing

Best regards
Shenhao Wang

-----Original Message-----
From: Michael Paquier <michael@paquier.xyz> 
Sent: Thursday, February 25, 2021 2:22 PM
To: Wang, Shenhao/王 申豪 <wangsh.fnst@fujitsu.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>; Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>; Emil Iggland <emil@iggland.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #15858: could not stat file - over 4GB

On Thu, Feb 25, 2021 at 06:07:06AM +0000, wangsh.fnst@fujitsu.com wrote:
> I noticed that this modification only commit into master branch, 
> there is still have a problem on 12.6 or 13.2 on Windows.
> 
> Do you have a plan to backpatch this commit into REL_12_STABLE or REL_13_STABLE ?

The change to be able to fix that stuff is invasive.  So, while I
don't really object to a backpatch of this change in the future, I
think that it would be wiser to wait until we get more feedback with
the release of Postgres 14 before doing a backpatch to older
versions.  So we are in a wait phase for the moment.

Thanks,
--
Michael

Commits

  1. Minor cleanup for win32stat.c.

  2. plperl.h should #undef fstat along with stat and lstat.

  3. Fix our Windows stat() emulation to handle file sizes > 4GB.