Horton

RE: Remove unused argument from ApplyLogicalMappingFile()

Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>

View thread View on postgr.es
From: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
To: 'Yugo Nagata' <nagata@sraoss.co.jp>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2026-01-28T05:18:15Z
Lists: pgsql-hackers 
Dear Nagata-san,

> I noticed that ApplyLogicalMappingFile() has an unused argument.
> If there is no specific reason for keeping it, I think it could be
> removed. I have attached a small patch that removes this argument.

Good catch. I found that ApplyLogicalMappingFile() has the argument since it was
introduced (b89e151) and was not used from the beginning. Maybe it was a
copy-to-paste mistake from UpdateLogicalMappings()?
I removed the argument and ran tests for subscription, they could be passed.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Commits

  1. Remove unused argument from ApplyLogicalMappingFile().