Thread
-
RE: Adding REPACK [concurrently]
Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com> — 2026-05-27T08:08:41Z
On Tuesday, May 26, 2026 11:32 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > On 2026-May-25, Zhijie Hou (Fujitsu) wrote: > > > After listening to the REPACK talk at pgconf.dev this year, I > > understand that WAL accumulation during REPACK CONCURRENTLY is not > > intended behavior. I think we can consider fixing this in the current > > release. Attached is the rebased patch, with comments adjusted based on > Chao Li's comments. > > You're right, this is a thinko. I'll look at your patch hoping to get it pushed > shortly. I wonder if we should add a TAP test to verify that WAL files are > actually removed? Sounds a bit excessive TBH, but maybe it isn't really. I tried a bit, and the test complexity and speed (< 1s) appear to be within acceptable limits. I'm attaching 0002 as a reference test. 0001 remains unchanged. Best Regards, Hou zj