RE: Conflict detection for update_deleted in logical replication

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

From: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: shveta malik <shveta.malik@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, vignesh C <vignesh21@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>

Date: 2025-08-29T06:19:44Z

Lists: pgsql-hackers

Attachments

v68-0003-Add-a-dead_tuple_retention_active-column-in-pg_s.patch (application/octet-stream) patch v68-0003
v68-0001-Introduce-a-max_retention_duration-option-to-sub.patch (application/octet-stream) patch v68-0001
v68-0002-Resume-retaining-the-information-for-conflict-de.patch (application/octet-stream) patch v68-0002

On Thursday, August 28, 2025 7:09 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> 
> On Thu, Aug 28, 2025 at 8:02 AM Zhijie Hou (Fujitsu)
> <houzj.fnst@fujitsu.com> wrote:
> >
> > I noticed that Cfbot failed to compile the document due to a typo
> > after renaming the subscription option. Here are the updated V67
> > patches to fix that, only the doc in 0001 is modified.
> >
> 
> I have made a number of cosmetic and comment changes in the attached atop
> 0001 patch. Kindly include in next version, if you think they are good to include.

Thanks ! The changes look good to me, I have merged them into V68 patch set.

Here is the new version patch set which also addressed Shveta's comments[1].

[1] https://www.postgresql.org/message-id/CAJpy0uD%3DMLy77JZ78_J4H3XCV1mCA%3DiUPHuFC5Vt4EKyj6zfjg%40mail.gmail.com

Best Regards,
Hou zj

Commits

Fix intermittent BF failures in 035_conflicts.
- 0f42206531b3 19 (unreleased) landed
Resume conflict-relevant data retention automatically.
- 0d48d393d465 19 (unreleased) landed
Fix intermittent test failure introduced in 6456c6e2c4.
- 01d793698f59 19 (unreleased) landed
Fix Coverity issue reported in commit a850be2fe.
- 5ac3c1ac22cb 19 (unreleased) landed
Add test to prevent premature removal of conflict-relevant data.
- 6456c6e2c4ad 19 (unreleased) landed
Post-commit review fixes for 228c370868.
- 1f7e9ba3ac4e 19 (unreleased) landed
Add max_retention_duration option to subscriptions.
- a850be2fe653 19 (unreleased) landed
Detect and report update_deleted conflicts.
- fd5a1a0c3e56 19 (unreleased) landed
Preserve conflict-relevant data during logical replication.
- 228c37086855 19 (unreleased) landed
Integrate FullTransactionIds deeper into two-phase code
- 62a17a92833d 19 (unreleased) cited
Improve checks for GUC recovery_target_timeline
- fd7d7b719137 19 (unreleased) cited
Prevent excessive delays before launching new logrep workers.
- fd519419c948 18.0 cited
Keep WAL segments by slot's last saved restart LSN
- ca307d5cec90 18.0 cited
Rework some code handling pg_subscription data in psql and pg_dump
- 08691ea958c2 18.0 cited
Use generateClonedIndexStmt to propagate CREATE INDEX to partitions.
- 68dfecbef210 18.0 cited