Horton
Menu

RE: [PATCH] Support automatic sequence replication

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

View thread
From: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Ajin Cherian <itsajin@gmail.com>, Ashutosh Sharma <ashu.coek88@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Amit Kapila <amit.kapila16@gmail.com>, shveta malik <shveta.malik@gmail.com>
Date: 2026-03-13T07:12:49Z
Lists: pgsql-hackers 
On Monday, March 9, 2026 11:17 AM Kuroda, Hayato/黒田 隼人 <kuroda.hayato@fujitsu.com> wrote:
> Few comments.

Thanks for the comments.

> 
> 03.
> Can we describe needed privileges? IIUC, initial sync needs the UPDATE
> privilege, additionally periodic synch needs SELECT privilege.

I could not find existing doc for the privilege required for table sync or
sequence sync, so I think we can consider that as a separate patch.

> 
> 04.
> ```
> +               long            sleep_ms = SEQSYNC_MIN_SLEEP_MS;
> ```
> 
> This is used in the for loop, make it the loop-specific variable.

This value should survive across sync loop as it's dynamically
adjusted in the loop.

Other comments have been addressed in latest version.

Best Regards,
Hou zj

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Don't include wait_event.h in pgstat.h

  2. Don't include proc.h in shm_mq.h

  3. Fix unsafe RTE_GROUP removal in simplify_EXISTS_query

  4. Add sequence synchronization for logical replication.