Horton

RE: POC: enable logical decoding when wal_level = 'replica' without a server restart

Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>

View thread
From: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>, shveta malik <shveta.malik@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-12-24T08:41:58Z
Lists: pgsql-hackers

Attachments

Hi,

I noticed a BF failure [1] related to this commit.

Commit 67c209 removes the WARNING for insufficient wal_level from the output,
but the WARNING may still appear on BF animals that default to
wal_level=minimal.

To avoid tests that produce varying messages based on wal_level, we could modify
the test to use ALTER PUBLICATION for verifying the same NOTICE. Attached is a
small patch addressing this issue.

We could also simply remove these tests but that seems to reduce the test
coverage a bit.

---- publication.out diff ----
SET client_min_messages = 'NOTICE';
CREATE PUBLICATION regress_pub_for_allsequences_alltables_withclause FOR ALL SEQUENCES, ALL TABLES WITH (publish = 'insert');
NOTICE: publication parameters are not applicable to sequence synchronization and will be ignored for sequences
+WARNING: logical decoding must be enabled to publish logical changes
+HINT: Before creating subscriptions, ensure that &quot;wal_level&quot; is set to &quot;replica&quot; or higher.
CREATE PUBLICATION regress_pub_for_allsequences_withclause FOR ALL SEQUENCES WITH (publish_generated_columns = 'stored');
NOTICE: publication parameters are not applicable to sequence synchronization and will be ignored for sequences
+WARNING: logical decoding must be enabled to publish logical changes
+HINT: Before creating subscriptions, ensure that &quot;wal_level&quot; is set to &quot;replica&quot; or higher.

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=thorntail&dt=2025-12-24%2006%3A31%3A02

Best Regards,
Hou zj