RE: Multivariate MCV list vs. statistics target

Hi, 

>Thanks for the report. Yes, this is clearly an omission. I think it would be better to use wording >similar to attstattarget, per the attached patch. That is, without reference to ALTER STATISTICS and >better explaination of what positive/negative values do. Do you agree?

Thank you for your comment.
I agree with the text you suggested.

Regards,
Noriyoshi Shinoda

-----Original Message-----
From: Tomas Vondra [mailto:tomas.vondra@2ndquadrant.com] 
Sent: Wednesday, March 18, 2020 9:36 PM
To: Shinoda, Noriyoshi (PN Japan A&PS Delivery) <noriyoshi.shinoda@hpe.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>; Thomas Munro <thomas.munro@gmail.com>; Jamison, Kirk <k.jamison@jp.fujitsu.com>; Dean Rasheed <dean.a.rasheed@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Multivariate MCV list vs. statistics target

Hi,

On Wed, Mar 18, 2020 at 04:28:34AM +0000, Shinoda, Noriyoshi (PN Japan A&PS Delivery) wrote:
>Hello,
>
>I found a missing column description in the pg_statistic_ext catalog document for this new feature.
>The attached patch adds a description of the 'stxstattarget' column to pg_statistic_ext catalog's document.
>If there is a better explanation, please correct it.
>

Thanks for the report. Yes, this is clearly an omission. I think it would be better to use wording similar to attstattarget, per the attached patch. That is, without reference to ALTER STATISTICS and better explaination of what positive/negative values do. Do you agree?


regards

>Regards,
>Noriyoshi Shinoda
>
>-----Original Message-----
>From: Tomas Vondra [mailto:tomas.vondra@2ndquadrant.com]
>Sent: Wednesday, September 11, 2019 7:28 AM
>To: Alvaro Herrera <alvherre@2ndquadrant.com>
>Cc: Thomas Munro <thomas.munro@gmail.com>; Jamison, Kirk 
><k.jamison@jp.fujitsu.com>; Dean Rasheed <dean.a.rasheed@gmail.com>; 
>PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
>Subject: Re: Multivariate MCV list vs. statistics target
>
>On Tue, Sep 03, 2019 at 02:38:56PM -0400, Alvaro Herrera wrote:
>>On 2019-Aug-01, Tomas Vondra wrote:
>>
>>> I'll move it to the next CF. Aside from the issues pointed by 
>>> Kyotaro-san in his review, I still haven't made my mind about 
>>> whether to base the use statistics targets set for the attributes. 
>>> That's what we're doing now, but I'm not sure it's a good idea after adding separate statistics target.
>>> I wonder what Dean's opinion on this is, as he added the current logic.
>>
>>Latest patch no longer applies.  Please update.  And since you already 
>>seem to have handled all review comments since it was Ready for 
>>Committer, and you now know Dean's opinion on the remaining question, 
>>please get it pushed.
>>
>
>OK, I've pushed this the patch, after some minor polishing.
>
>
>regards
>
>-- 
>Tomas Vondra                  http://www.2ndQuadrant.com 
>PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
>
>



-- 
Tomas Vondra                  http://www.2ndQuadrant.com 
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services