Horton

RE: WIP: Covering + unique indexes.

Shinoda, Noriyoshi <noriyoshi.shinoda@hpe.com>

View thread View on postgr.es
From: "Shinoda, Noriyoshi" <noriyoshi.shinoda@hpe.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Teodor Sigaev <teodor@sigaev.ru>, Peter Geoghegan <pg@bowt.ie>
Cc: Jeff Janes <jeff.janes@gmail.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Date: 2018-04-09T14:07:00Z
Lists: pgsql-hackers

Attachments

Hi, 

I tested this feature and found a document shortage in the columns added to the pg_constraint catalog.
The attached patch will add the description of the 'conincluding' column to the manual of the pg_constraint catalog.

Regards,
Noriyoshi Shinoda

-----Original Message-----
From: Teodor Sigaev [mailto:teodor@sigaev.ru] 
Sent: Monday, April 9, 2018 3:20 PM
To: Peter Geoghegan <pg@bowt.ie>
Cc: Jeff Janes <jeff.janes@gmail.com>; Alexander Korotkov <a.korotkov@postgrespro.ru>; Anastasia Lubennikova <a.lubennikova@postgrespro.ru>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: WIP: Covering + unique indexes.

Thank you, pushed.


Peter Geoghegan wrote:
> On Sun, Apr 8, 2018 at 11:18 AM, Teodor Sigaev <teodor@sigaev.ru> wrote:
>> Thank you, fixed
> 
> I suggest that we remove some unneeded amcheck tests, as in the 
> attached patch. They don't seem to add anything.
> 

-- 
Teodor Sigaev                      E-mail: teodor@sigaev.ru
                                       WWW: http://www.sigaev.ru/

Commits

  1. Adjust INCLUDE index truncation comments and code.

  2. Add commentary explaining why MaxIndexTuplesPerPage calculation is safe.

  3. Indexes with INCLUDE columns and their support in B-tree

  4. Add amcheck verification of heap relations belonging to btree indexes.

  5. Doc: move info for btree opclass implementors into main documentation.

  6. Doc: mention that you can't PREPARE TRANSACTION after NOTIFY.

  7. Remove dedicated B-tree root-split record types.

  8. Restructure index access method API to hide most of it at the C level.

  9. Split _bt_insertonpg to two functions.

  10. Major overhaul of btree index code. Eliminate special BTP_CHAIN logic for