Re: [HACKERS] minor improvement to libpq++ ...

Maarten Boekhold <maartenb@dutepp0.et.tudelft.nl>

From: Maarten Boekhold <maartenb@dutepp0.et.tudelft.nl>
To: Andreas Hauck <Andreas.Hauck@earthling.net>
Cc: pgsql-hackers@postgreSQL.org
Date: 1998-06-18T20:59:29Z
Lists: pgsql-hackers
On Thu, 18 Jun 1998, Andreas Hauck wrote:

> Hi y'all,
> 
> to unify the framework of the look an feeling of c++ programs relying on
> libpq++ I propose to migrate to a consistant use of 'string' to represent any
> text rather than 'char *'.
> 
> Especially I refer to PgConnection::Exec(char *), ExecCommandOk() and
> ExecTuplesOk(). It is very easy to switch over to the use of strings: in the
> headerfiles only (char * --> string) has to be changed and in the
> corresponding c++ files, the call to the c-functions becomes e.g.
> PQexec(pgConn, query) --> PQexec(pgConn, query.c_str()).
> 
> The old style call via 'char *' would still be possible, since 'char *' is
> automatically convertet to 'string'. 

I'm all for it, but are you sure about the automatic conversion? I don't 
think it does that.... I just did a grep on bastring.h, and it doesn't 
show a char* operator. And string.c_str() returns a const char*, which 
gives all sorts of errors/warning during compile.....

Maarten

_____________________________________________________________________________
| TU Delft, The Netherlands, Faculty of Information Technology and Systems  |
|                   Department of Electrical Engineering                    |
|           Computer Architecture and Digital Technique section             |
|                          M.Boekhold@et.tudelft.nl                         |
-----------------------------------------------------------------------------