Thread
-
Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc
Tom Lane <tgl@sss.pgh.pa.us> — 1999-10-08T23:01:04Z
Bruce Momjian <maillist@candle.pha.pa.us> writes: > New code in Makefile.alpha is: > /* some platforms define __alpha, but not __alpha__ */ > #if defined(__alpha) && !defined(__alpha__) > #define __alpha__ > #endif OK, so we're going to standardize on __alpha__ to recognize that platform? OK by me, unless the Alpha users know a reason not to. But the above doesn't belong in Makefile.alpha does it? I'd have thought include/port/alpha.h, since __alpha__ is being looked for by C code not makefiles. BTW, a quick glimpse shows no occurrences of __alpha except in contrib/int8/int8.c, which is presumably unmaintained dead code now that int8 is in the mainstream. Shouldn't we delete contrib/int8 entirely? regards, tom lane
-
Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc
Bruce Momjian <maillist@candle.pha.pa.us> — 1999-10-09T01:30:47Z
> Bruce Momjian <maillist@candle.pha.pa.us> writes: > > New code in Makefile.alpha is: > > > /* some platforms define __alpha, but not __alpha__ */ > > #if defined(__alpha) && !defined(__alpha__) > > #define __alpha__ > > #endif > > OK, so we're going to standardize on __alpha__ to recognize that > platform? OK by me, unless the Alpha users know a reason not to. > > But the above doesn't belong in Makefile.alpha does it? I'd have > thought include/port/alpha.h, since __alpha__ is being looked for > by C code not makefiles. Moved to port/alpha.h, both trees. > > BTW, a quick glimpse shows no occurrences of __alpha except in > contrib/int8/int8.c, which is presumably unmaintained dead code now > that int8 is in the mainstream. Shouldn't we delete contrib/int8 > entirely? contrib/int8 removed. -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
-
Re: [BUGS] 6.5.2 broken on alpha/Tru64 Unix 4.0d/cc
Pedro J. Lobo <pjlobo@euitt.upm.es> — 1999-10-11T08:37:14Z
On Fri, 8 Oct 1999, Tom Lane wrote: >Bruce Momjian <maillist@candle.pha.pa.us> writes: >> New code in Makefile.alpha is: > >> /* some platforms define __alpha, but not __alpha__ */ >> #if defined(__alpha) && !defined(__alpha__) >> #define __alpha__ >> #endif > >OK, so we're going to standardize on __alpha__ to recognize that >platform? OK by me, unless the Alpha users know a reason not to. I don't see any. The only problem I can see is that __alpha (or __alpha__) used to mean "Alpha/Tru64 Unix", and this is no longer true because of Alpha/Linux. If there is any place in the code that's valid only for Alpha/Tru64, then __osf__ should be used. For example, s_lock.h uses the msem_xxx functions to implement spinlocks when gcc is not used. These functions are related to msemaphores, which are semaphores that live in shared memory segments (or "mmap"ed files). I don't know wheter this group of functions is specific to Tru64 Unix, but at least FreeBSD doesn't have them. If Alpha/Linux doesn't have them, then __osf__ should be used there instead of __alpha__ (or at least a combination of both). Regards, Pedro. -- ------------------------------------------------------------------- Pedro José Lobo Perea Tel: +34 91 336 78 19 Centro de Cálculo Fax: +34 91 331 92 29 E.U.I.T. Telecomunicación e-mail: pjlobo@euitt.upm.es Universidad Politécnica de Madrid Ctra. de Valencia, Km. 7 E-28031 Madrid - España / Spain